search

Shelf-nu / shelf.nu

shelf is open source Asset Management Infrastructure for absolutely everyone.
https://shelf.nu
GNU Affero General Public License v3.0
1.67k stars 149 forks source link

[Feature request]: Show who created a booking on the booking page #969

Open carlosvirreira opened 2 months ago

carlosvirreira commented 2 months ago

Contact Details

No response

Is your feature request related to a problem? Please describe?

I am on a mobile phone. I open a booking and I see an issue.

On desktop, when I go to the booking page. I have a column that shows me who created a booking. That way I can get in touch with this person to discuss things around the booking.

I have no way to do this on mobile.

Describe the solution you'd like

Add the booking creator data on the booking page on mobile and desktop.

Describe alternatives you've considered

No response

Additional context

No response

DonKoko commented 3 weeks ago

@jurrejansen can u make a quick design for this? I want to make a bounty. Lets keep it super simple.

carlosvirreira commented 3 weeks ago

I think the issue here is that, although it looks nice on mobile the information on the booking tab. Is not giving much value.

I can see 'name' 'status' so it is not really giving me insight on the booking so I can take a quick action.

Things I should be able to answer by going to the booking tab on mobile for 1 asset:

DonKoko commented 3 weeks ago

OKey based on the issue title i was thinking about something completely different. You are talking about the asset page but based on the original issue i thought you were talking about the booking page. I think this is relevant in both cases. Lets decide which case this issue is for and create a different issue for the other case. Then we can tackle them both at some point.

jurrejansen commented 3 weeks ago

@DonKoko @carlosvirreira Perhaps we should then consider to not use the simplified tables on mobile and implement the horizontal scroll globally for tables. It works better than I expected anyways when I see tables like Custom fields for example. Would be best that only the content and column header are scrollable though.

Perhaps start with the Booking index?

Screenshot 2024-07-02 at 13 48 35

https://github.com/Shelf-nu/shelf.nu/assets/76112272/f573d66b-172b-4b0b-b99c-03a009129f03

carlosvirreira commented 3 weeks ago

If we do sidescroll, we have to find a way to make it super clear you can scroll to reveal more. At the moment not sure what/how.

jurrejansen commented 3 weeks ago

I think in most cases it is going to be pretty clear when the cells of a second column in a table are partly off screen. However the underlined approaches I kinda like but they're probably not 'keeping it simple'.

Screenshot 2024-07-02 at 14 35 12

Screenshot 2024-07-02 at 14 45 10

DonKoko commented 2 weeks ago

@jurrejansen good points. I think the sticky first column is too much on mobile. There will be very little space left, but for sure something I would implement on desktop once we start adding more columns and we need more space.

@carlosvirreira can we agree we do the first option for now for mobile? Screenshot 2024-07-12 at 10 12 16 Then I can make a bounty and assign.

carlosvirreira commented 2 weeks ago

I approve and commit to the option picked. Let's proceed.