Remove colon from Basic scheme in generated HTTP Authorization header

ShellRechargeSolutionsEU / ocpp

Open Charge Point Protocol

GNU General Public License v3.0

201 stars 64 forks source link

Remove colon from Basic scheme in generated HTTP Authorization header #38

Closed msqr closed 4 years ago

msqr commented 4 years ago

Per RFC 7617 the HTTP Authorization scheme for basic authentication is Basic, but SimpleClientWebSocketComponent is writing the scheme as Basic: (with a colon). I discovered this problem when trying to use the docile-charge-point simulator against a Central System that requires basic authentication.

coveralls commented 4 years ago

Coverage remained the same at 85.357% when pulling 3400258d6a7c6ebb0b32cceb40240197d87f76c3 on SolarNetwork:master into 1712fedba1109be4297c83d016e3d890d35332da on NewMotion:master.

coveralls commented 4 years ago

Coverage remained the same at 85.357% when pulling 3400258d6a7c6ebb0b32cceb40240197d87f76c3 on SolarNetwork:master into 1712fedba1109be4297c83d016e3d890d35332da on NewMotion:master.

reinierl commented 4 years ago

@sbmpost It looks OK. Can you please merge it?

azolotko commented 4 years ago

LGTM

azolotko commented 4 years ago

Thanks @msqr and @reinierl !