search

ShelterTechSF / askdarcel-web

The "Ask Darcel" web app.
GNU General Public License v3.0
28 stars 22 forks source link

Add ucsf partner logo #1307

Closed schroerbrian closed 1 year ago

schroerbrian commented 1 year ago

Made updates to the home page partners. These include markup/CSS changes for the list of logos. Adding that extra logo causes them to wrap to the next line, which made them look awkward with our current setup.

I also added the logo to the SFSG about page as well as the LinkSF page. I'm not exactly sure if we need to keep the LinkSF page updated or even include the UCSF logo there, but it contains our other logos, so I added it for the time being. I'm not sure we get much traffic on LinkSF as it is, anyhow.

I think the UI that we currently have is not perfect, and it can look awkward on smaller screens, but maybe we should wait until our exec discussion before perfecting the logo UI.

Screen Shot 2023-10-20 at 3 59 04 PM Screen Shot 2023-10-20 at 3 52 58 PM
schroerbrian commented 1 year ago

LGTM, I left a few detailed CSS-related comments, but I don't think they are blockers for this to merge.

Thanks for reviewing! I've added your suggested changes, and everything looks better. Good catch noticing the effects of removing the header element from the logo li elements. See updated screenshots below:

Screen Shot 2023-10-23 at 12 11 34 PM

Screen Shot 2023-10-23 at 12 13 41 PM