While reviewing this, I realized there is one point of naming confusion – the pre-existing expandList functionality, which allows mobile users to pop up the search results component over the map. For the purposes of this feature, the search results enhancements, the naming convention I've chose to represent expanded or collapsed search results is expandSearchResults, (with some variation depending on element etc).
To rectify possible confusion within the SearchResults component, I renamed expandList to overlayMapWithSearchResults. There are instances of expandList in the other components, but, given these components do not contain references to the expandSearchResults feature, and mostly to keep this PR less complicated, I didn't change the var nams there. They can be changed at a later time.
Note: there were a couple features that are part of this ticket that I did not implement – the sidebar improvements and displaying the selected eligibilities within service results. I created another ticket to handle those here
…sults and UI improvements
While reviewing this, I realized there is one point of naming confusion – the pre-existing
expandListfunctionality, which allows mobile users to pop up the search results component over the map. For the purposes of this feature, the search results enhancements, the naming convention I've chose to represent expanded or collapsed search results isexpandSearchResults, (with some variation depending on element etc).To rectify possible confusion within the SearchResults component, I renamed
expandListtooverlayMapWithSearchResults. There are instances ofexpandListin the other components, but, given these components do not contain references to theexpandSearchResultsfeature, and mostly to keep this PR less complicated, I didn't change the var nams there. They can be changed at a later time.Note: there were a couple features that are part of this ticket that I did not implement – the sidebar improvements and displaying the selected eligibilities within service results. I created another ticket to handle those here