schroerbrian
commented
6 months ago This LGTM now, thanks for making those changes! I guess we'll need the API to be implemented before we can fully test that this works, but I don't think there's any harm in merging this in, since the feature is guarded by being logged in, which isn't officially "released" yet.
Thanks! I just pushed a couple more small changes. including changing the folder to star. I was looking into altering the New Folder UI but rather than spending time breaking my brain, I think it'd be good to talk to design or have people try it out on Staging. Given the time constraints on this project, I'll just merge this in and we can go over it again once we are further along
Unfortunately, the sort of pseudo-dropdown element listing Bookmark Folders required a lot of custom UI. I didn't think it'd be possible to code this using a standard Select dropdown. Thus, there are some accessibility compromises that I had to make, and it is maybe not as elegant as it could be. In hindsight, I probably could have used React-Select's
createableselect component, but that is also kind of weird UX, and doesn't really match the designs. Anyhow this took me a little longer than I would have liked. I will plan to use it as an edit modal to edit existing bookmarks listed on the navigator dashboard pageNote: There are also some extra commits listed but I think that is because I had created this branch off of other feature branches prior to merging them in using rebase