Closed ezynda3 closed 3 years ago
Should be fixed now
@ezynda3 looks good!
There seems to be a conflict with your yarn.lock.
@ezynda3 the factory contract looks good
Tasks left to be done:
Remove deprecated buidler folder
Add these commands for hardhat into package.json
and finish the TODOs
"chain": "buidler node",
"test": "buidler test --network buidlerevm",
"compile": "buidler compile",
"deploy": "buidler run scripts/deploy.js --show-stack-traces && buidler run scripts/publish.js",
"watch": "node scripts/watch.js",
"accounts": "buidler accounts",
"balance": "buidler balance",
"send": "buidler send"
}
Fix problems with Ownership on Facets
This should be contained in another PR that merges into this one before we merge to master. This will still count as 2 PRs in sourcecreds eyes
create vscode workspace
fix compiler recommendations
add deployment scripts
This is a big commit but only because I copied the contracts over from the buidler package. This should be merged so I can contiue with the Factory contract.