ShenaniganDApp / shenanigan-monorepo

17 stars 4 forks source link

Fetch username and address for donation modal #307

Closed prasadwalvekar closed 3 years ago

prasadwalvekar commented 3 years ago

Fixes

Live: Donation Modal User data

Changes

Add fragment to <DonationModal /> component to fetch username, addresses
Add address inside a <Blockie /> component

prasadwalvekar commented 3 years ago

Need some clarification regarding the usage of <Blockie /> component as the figma mockup link that was shared in the issue does not match what I see in the emulator if I use a component. Please see this loom. @youngkidwarrior

https://www.loom.com/share/1a0fb41eb3bd4884826cd87397625f31

youngkidwarrior commented 3 years ago

@prasadwalvekar No blockie component needed there!

We will have profile images available for the places the figma requires picture components soon.

Question: Does this PR rely on changes from #306?

prasadwalvekar commented 3 years ago

@prasadwalvekar No blockie component needed there!

@youngkidwarrior I used the <Blockie /> component as conveyed in this issue description.

Have removed the <Blockie /> component now.

Question: Does this PR rely on changes from #306?

Both PRs are using different fragments to pull in different data.

306 pulls in live challenge - title, content, image

307 pulls in username and address