ShenaniganDApp / shenanigan-monorepo

17 stars 4 forks source link

Handle TSLint Errors #404

Open youngkidwarrior opened 2 years ago

youngkidwarrior commented 2 years ago

User Story

As a ...

Developer

I want ...

To ensure type safety while reviewing code

So that ...

We avoid silly bugs and runtime errors

Comments and Outliers

Currently we have a few 100 TSLint errors. This is a big issue. It might benefit us to pair on this task.

Some errors are more difficult than others. For example, circular dependency errors can be a huge pain in the ass and require a great deal of file restructuring. Generally the rules @youngkidwarrior setup are industry standard, but they can be difficult to accomplish and may benefit from a rule change to increase dev speed.

Acceptance Criteria

Scenario:

Given I am running compiling and code inside the monorepo

When I run the linter Then it should only allow commits/pushes when the linter is succesful