ShendoXT / memcardrex

Advanced PlayStation 1 Memory Card editor
GNU General Public License v3.0
432 stars 53 forks source link

When exporting RAW single save, everything in the destination path after and including "." is ignored #36

Closed yousie642 closed 1 year ago

yousie642 commented 2 years ago

This can be reproduced by exporting to a path like C:\Users\[username]\Downloads\MemcardRex.1.9.cd98032\BASLUS-006640 with BASLUS-006640 being the file name of the RAW single save. You will instead wind up with a RAW single save called MemcardRex under C:\Users\[username]\Downloads

This is also seen when exporting a RAW single save where the save file identifier includes a . like in Tales of Phantasia image Exporting this save as a RAW single save attempts to name the file as BISLPSP01770.TOP.C (on 1.9.2b7a018 at least. There's a different issue on 1.9.cd98032 when you go to export where it replaces the identifier with a seemingly random string of characters). Instead, you wind up with a file called BISLPSP01770

ShendoXT commented 1 year ago

Oh snap, you are absolutely right. I even know what the issue is... Save file dialog leaves extensions when selecting file type even when raw save is selected. So my solution was to trim everything after the dot since it "must" be an extension which save file dialog did not clear...

I'll just have to remove this piece of code and rely on user to trim the extension if the stupid save dialog leaves it...

ShendoXT commented 1 year ago

Fixed as of 75fb97c21faae227f8fdd17a8e319c26ce214515