search

Sheribaby / swtoolkit

Automatically exported from code.google.com/p/swtoolkit
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Use of InstallUsingLink for miscellaneous files during coverage builds may cause these files to be unnecessarily installed on subsequent builds #13

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. hammer.bat -k MODE=coverage-win --verbose
2. After successful build, repeat step 1.

What is the expected output? What do you see instead?
No build operations should occur as no code as changed.

In some cases, such as when code signing after instrumentation, this 
results in Hammer thinking it needs to reinstall the files every time a 
build is run. This was observed for .msi and .msp files.

What version of the product are you using? On what operating system?
0.9.1
Windows XP SP3

Please provide any additional information below.
In _CoverageInstall() in target_platform_windows.py, files that are not 
.pdb, .exe, or .dll are installed with env['PRECOVERAGE_INSTALL'], which is 
InstallUsingLink. This does not happen if I replace 
env['PRECOVERAGE_INSTALL'] with the following:
  env.Execute('copy "%s" "%s"' % (source, dest))

Linking also causes these miscellaneous files to be signed in the obj 
directory whereas EXEs and DLLs are not signed in the obj directory.

Linking can be confusing when debugging issues on Windows, since it is not 
commonplace in Windows and the use of linking is hard to track down in all 
the SCT scripts.

Original issue reported on code.google.com by ddor...@google.com on 7 Jan 2010 at 7:41