search

Sherlock-YH / pe

0 stars 0 forks source link

DG confusing arrow lines for Class Diagram of SecretStorage Component #14

Open Sherlock-YH opened 1 year ago

Sherlock-YH commented 1 year ago

Maybe try to clean up this diagram to make sure the lines do not tangle each other.

image.png

nus-pe-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

DG confusing arrow lines for Class Diagram of SecretStorage Component

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Same for this diagram

image.png

[original: nus-cs2113-AY2223S2/pe-interim#1592] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is subjective. It is easy to trace as there are only a few arrows. And all subclasses of Secrets are connected to SecretSearcher and SecretEnumerator. This is easily derived from the fact that there are 5 coming out of SecretSearcher and SecretEnumerator each and 2 coming out of each subclass of Secret.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]