search

Sherlock-YH / pe

0 stars 0 forks source link

add Wifi Password error #5

Open Sherlock-YH opened 1 year ago

Sherlock-YH commented 1 year ago

Wifi password should have at least 8 digits or characters but it allows for 8888888 which contains only seven '8'.

image.png

soc-se-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

To keep our program simple and consistent, we do not follow any WiFi password restrictions such as with WPA2. We did not mention any restrictions for WiFi password in our UG or DG. However, this is a valid real-world restriction which we may consider to implement in the future.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unrestricted length on wifi password

image.png

Usually, wifi password WPA2 has a maximum length of 63 characters. There may be a need to constraint it here if possible.

[original: nus-cs2113-AY2223S2/pe-interim#1318] [original labels: severity.VeryLow type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

To keep our program simple and consistent, we do not follow any WiFi password restrictions such as with WPA2. We did not mention any restrictions for WiFi password in our UG or DG. However, this is a valid real-world restriction which we may consider to implement in the future.

However in our current design we minimised restriction here since, the max length of Wifi Passwords may change over the years as the security requirements of passwords increase over time (due to increasing threat of hacking).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]