search

ShervanGharari / EASYMORE

EASYMORE; EArth SYstem MOdeling REmapper
GNU General Public License v3.0
24 stars 21 forks source link

Descriptions for the `remapped` file is missing #78

Open kasra-keshavarz opened 8 months ago

kasra-keshavarz commented 8 months ago

A brief description of the remapped .csv file could be helpful. The starting point for rows and columns in the file is not described properly, and unsure whether indexing starts from 0 or 1.

ShervanGharari commented 8 months ago

good point! the indexing is Python indexing so start from 0. calculated here: https://github.com/ShervanGharari/EASYMORE/blob/main/src/easymore/remapper.py#L1572 used here: https://github.com/ShervanGharari/EASYMORE/blob/main/src/easymore/remapper.py#L1947 The idea to have the remapping file as NC was to include some description as well (if time allows!). It will be added in the next minor release.

kasra-keshavarz commented 8 months ago

The .nc could be very informative for this. This can help with mizuRoute and similar programs as well?