search

SherwynNg / pe

0 stars 0 forks source link

Adding bookings allow overlap #15

Open SherwynNg opened 3 months ago

SherwynNg commented 3 months ago

Steps to reproduce:

  1. Input: "book -n CS2103T Consultation -s 2024-04-21 14:00 -e 2024-04-21 16:00 -note TEST"
  2. Input: "book -n CS2103T Consultation -s 2024-04-21 15:00 -e 2024-04-21 16:00 -note TEST"

Expected: I expected an error message, which does not allow me to add bookings that are overlapped with my existing booking.

Actual: Allow the adding of bookings that have overlapped.

Screenshot 2024-04-19 at 5.01.02 PM.png

nus-se-bot commented 3 months ago

Team's Response

We currently allow bookings to overlap for flexibility. For example, if you have a zoom call that doesn't require much attention as well as a casual lunch at the same time :) Only complete duplicates not allowed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: If they allow overlap bookings for flexibility, and from the example that they gave, they should allow complete duplicates as well. Because for a zoom call that doesn't require much attention as well as a casual lunch at the same time can happen and end during the same time as well.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]