SherwynNg / pe

0 stars 0 forks source link

Adding duplicates contatcs #5

Open SherwynNg opened 4 months ago

SherwynNg commented 4 months ago

Steps to reproduce:

  1. input: "add -n Bob Smith -p 98765432 -e bsmith@example.com -a Bedok 693021"
  2. input: "add -n bob Smith -p 98765432 -e bsmith@example.com -a Bedok 693021"

Expected: I expected it to return "This person already exists in the addressbook" since the name, email and phone number is the same.

Actual: It allows me to add to the contacts.

Screenshot 2024-04-19 at 4.19.43 PM.png

nus-pe-script commented 4 months ago

Team's Response

Rejected - allow similar names for flexibility

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplication detection of contacts: Check names without case sensitivity

The three john doe in the screenshot actually have the totally same contact information. However, this kind of duplication is allowed in the app. There should be an error or at least a warning before I want to add quite similar contact information, because it's quite likely that these three people are actually 1 person. Screenshot 2024-04-19 at 4.53.49 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#5550] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Rejected - we allow similar names for flexibility

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I feel that this bug is valid as contacts with the same name but case sensitive, same email, contact and address should be reported as a duplicate. The checking of names should not be case sensitive as john doe, John Doe, John doe should refer to the same person. To allow flexibility, they can choose to throw them an error instead of adding them right away.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I feel that this should remain as Medium because it occurs frequently. After having a long list of contacts, users might forget if they have a particular person added in the list and they will try adding them again, each time with different format and capitalisation. Hence, Dook will allow the user to add contacts with same name, email and address but each time differing only in case sensitivity.