SherwynNg / pe

0 stars 0 forks source link

Adding a prof that is currently in the address book #9

Open SherwynNg opened 4 months ago

SherwynNg commented 4 months ago

Steps to reproduce:

  1. input: "prof -a halim"
  2. input: "prof -a steven"

Expected: I expected it to show a message indicating that that prof is already in the address book. Might want to include in the UG that it will not show a duplicate message.

Actual: It shows "Professors Added!" which can be quite misleading.

Screenshot 2024-04-19 at 4.39.03 PM.png

nus-pe-script commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add professors: Wrong message shown even if no new profs are added in

When I enter prof -n ben leong twice, the second time doesn't add any new professors in. However, the result box still displays Professors Added!, which is totally same as the first time, which will be a little misleading to the users.


[original: nus-cs2103-AY2324S2/pe-interim#4647] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted - minor cosmetic issue but does not change any user functionality since the Prof contact remains in the contact book.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]