[Terraqueous] [1.4.11] Non-standard tools with empty button options in the Ender Table

[NotAVerb]

Some unusual tool items have these blank options appear. These options accept any secondary item and give nothing when selected. I'm guessing this is related to the new CraftTweaker integration.

Upon further testing it is possible to use these tools in recipes, but if a value below the required secondary item is supplied first the empty recipes take over.

[ShetiPhian]

Could I get the script, I'm likely missing something thus causing the code to process wrong.

[NotAVerb]

The empty recipes can be encountered with only terraqueous installed. Placing a colorizer in the table works as an example.

I added this line after encountering the issue to test if added recipes would override the null recipes. mods.terraqueous.EnderTable.addRecipe(<cyclicmagic:tool_launcher>, <cyclicmagic:tool_rotate>, 2, 1, "A Propulsive Staff", true, <minecraft:slime_ball> * 16); It of course requires cyclic.

Edit: Flint & Steel and the Shears have empty recipes too, Clock and Compass don't.

Edit2: It's not the CraftTweaker integration. I just tested 1.4.10 and the empty recipes show up for the aforementioned items.

[ShetiPhian]

Gotcha, I thought the error was only appearing with a CraftTweaker script.

After a quick test, it may be items that are enchantable but have no valid enchants. Have to debug the code to find out the cause.

That is it. By default, any item that is limited to a stack of 1 and is damageable is enchantable. With no valid enchants to apply the list is empty, I wasn't resetting a variable when this happened. This bug would have been in for a while now.

[ShetiPhian]

Turns out there is issue with the available choices, when an enchantable item also has a special recipe []they're not refreshing unless you completely empty a slot.

Also not sure whats up with the CraftTweaker optional. This works: mods.terraqueous.EnderTable.addRecipe(<minecraft:dirt>, <minecraft:book>, 2, 1, "make dirt", true, <minecraft:slime_ball> * 16);

But this doesn't: mods.terraqueous.EnderTable.addRecipe(<minecraft:dirt>, <minecraft:book>, 2, 1, "make dirt", <minecraft:slime_ball> * 16);

Both have supporting methods https://gist.github.com/ShetiPhian/f3c0f119b75c7786718f6d7da0141758

[NotAVerb]

There's also a bit of weirdness with plain books. This recipe works if you insert the book after inserting the nether star. val mending = <minecraft:enchanted_book>.withTag({StoredEnchantments: [{lvl: 1 as short, id: 70 as short}]}); mods.terraqueous.EnderTable.addRecipe(mending, <minecraft:book>, 5, 15, "Enchant with Mending", true, <minecraft:nether_star>); Placing the star second gives this.

[ShetiPhian]

If interested, here is a compile of my test build. http://www.mediafire.com/file/8l4ckhhmy6c63o9/terraqueous-1.12.0-1.4.12.jar

I ran out of free time, squeezed in the Burnium fix, testing is lacking. should fix:

• logged error at startup when craft tweaker is missing
• multitool being able to mine bedrock
• the invalid recipes (limited testing)
• available choices not updating (barely tested)
• Burnium burning entities that are immune to fire (untested)

not fixed:

• addRecipe requiring the boolean when including the optional material (I think this might be a CraftTweaker bug, the method exists but it can't find it when the optional field is populated)

[NotAVerb]

The staff script seems to be working fine now. Shears, the Flint and Steel, and Cyclic's staves no longer have empty recipes. Burnium no longer burns pigmen. Blazes seem fine too. The crystals still deal damage but I think that's intentional. Choices seem to update. I intend on testing to see if it's possible to have more than three button options tied to an ingredient combo later.

By the way, the third button option often has text wrap off of the gui.

[ShetiPhian]

New build uploaded to Curse https://minecraft.curseforge.com/projects/terraqueous/files/2554193