search

Shevchik / AutoSaveWorld

Bukkit plugin that provides advanced bukkit server management capabilities. Supports automatic saves, backups, stale data purge, plugin management, and more.
GNU General Public License v3.0
35 stars 36 forks source link

Fixed small mistake and hotfixed FTP problem #36

Closed marcsello closed 7 years ago

marcsello commented 7 years ago

Hey there!

I've encountered some problems backing up to a server that uses absolute paths instead of relative in the directory listing. This is not a 100% perfect solution, not even best performance, so please revise it.

I've also found a small mistake in VirtualFileSystem.java that caused random directories to be created in the target folder.

Shevchik commented 7 years ago

Fixed the VFS. NLST command should return the names of files in directory only, so the ftp server that returns absolute paths is simply broken.

marcsello commented 7 years ago

Yeah, but since those servers exists, and there are cases where you can't do anything to it (like in my situation, the FTP server is not hosted by me) it would be nice to have support for them as well (instead of a random "Directory creating failed" exception that tells nothing about the problem). All FTP clients I used had no problem with absolute listing, so it was weird that this plugin does have.

Shevchik commented 7 years ago

Well, maybe some workaround can be added to getEntries method itself.