search

ShiangHu / Xi-Pi

a nonparametric model for neural power spectra decomposition
GNU General Public License v3.0
5 stars 2 forks source link

issue unknown variables/functions #3

Open GuidoWiersma opened 5 months ago

GuidoWiersma commented 5 months ago

Dear authors,

Last week I read your paper "ξ-π: A Nonparametric Model for Neural Power Spectra Decomposition" with great interest. While following the instructions as mentioned on this GitHub page, I encountered some difficulties.

When I run the scmem_unim function as described in the tutorial, within the initialfit1.m file (which is called by the scmem_unim.m script), the variable "plotflag" is undefined and hence unknown. Since the plotflag variable is (if I'm not mistaken) only introduced to plot the periodic and aperiodic components, I tried to manually add this variable when calling for the function. However, I then ran into the second error, which denotes that the function "chckxywp" is undefined. Further inspecting the code, I identified more functions potentially undefined, such as "pkextrem1" or "plotspfit". When changing the settings while calling scmem_unim such that the periodic component won't be detected ( e.g. by making the peak_min_value very big), the algorithm works just fine since it doesn't find a periodic component and doesn't call upon the undefined functions/variable.

I would greatly appreciate your insights and guidance in resolving these implementation challenges. I'm looking forward to your responses!

ShiangHu commented 5 months ago

Thank you for your feedback. @annie-jpg please help Guido solve this.