search

ShichenLiu / SoftRas

Project page of paper "Soft Rasterizer: A Differentiable Renderer for Image-based 3D Reasoning"
MIT License
1.24k stars 156 forks source link

Bug? #11

Closed Liusifei closed 5 years ago

Liusifei commented 5 years ago

https://github.com/ShichenLiu/SoftRas/blob/d7447be86ad3c8f6d6b22041ed0c550144bf5a9e/soft_renderer/cuda/soft_rasterize_cuda_kernel.cu#L598 atomicAdd(&grad_texture[k], zp_softmax grad_t); should be atomicAdd(&grad_texture[3j+k], zp_softmax * grad_t);

ShichenLiu commented 5 years ago

Hi,

Yes you are right! I have fixed the bug! Thanks for pointing this out!