search

Shift3 / boilerplate-client-react

The Bitwise standard starting point for new React web projects.
7 stars 10 forks source link

[Enhancement] - Dark mode reverts to light mode default when refreshing browser #609

Closed aliciajbrookshire closed 2 years ago

aliciajbrookshire commented 2 years ago

Environment

Asus Laptop OS: Windows 10 Home Google Chrome ChromeVersion 102.0.5005.115 (Official Build) (64-bit) Firefox Version 101.0 (64-bit) Android Pixel 4 Up-to-date Chrome and Firefox

Description

When refreshing the browser dark mode reverts to light mode

Expected Behavior

I expected the screen to remain in dark mode

Actual Behavior

It changed back to light mode and I had to toggle it back to dark mode

Steps to Reproduce Issue

PC:

  1. Toggle from light mode to dark mode by clicking on the moon icon
  2. Refresh browser
  3. Observe that screen reverts to light mode

Phone:

  1. Click on hamburger menu
  2. Toggle from light to dark mode by clicking on the moon icon
  3. Refresh browser
  4. Observe that screen reverts to light mode

Screenshots

https://user-images.githubusercontent.com/106767049/179088238-adcf2a84-aa92-4b02-aa1f-06f33cb42c93.mp4

fluturecode commented 2 years ago

Please reference the fix for this issue here https://github.com/Shift3/boilerplate-client-react/pull/659

aliciajbrookshire commented 2 years ago

@fluturecode this passed retest on desktop and mobile