search

Shift3 / boilerplate-client-react

The Bitwise standard starting point for new React web projects.
7 stars 10 forks source link

Fixes the filter dropdown border blending issue #648

Closed joshwingreene closed 2 years ago

joshwingreene commented 2 years ago

Changes

  1. Adds a card border property to the dark and light theme files. For the dark theme, the border color is the same as the nav bar background. For the light theme, the order is set to none (this matches the styling of the card component from React-Bootstrap).
  2. Adds a darkGray color to colors.ts. Since the dark gray color of the navbar is now used in two places, it made sense to add it to the colors file.

Purpose

Fixes the filter dropdown border blending issue

Testing Steps

  1. Pull in the changes to your local copy of this branch and run it alongside the dj_starter_demo repo.
  2. Open the filter menu for both the light and dark menus on either the User or Agent List Views.

Screenshots

filter menu fix

Closes #620

joshwingreene commented 2 years ago

Data Table QA pass.