search

Shift3 / boilerplate-client-react

The Bitwise standard starting point for new React web projects.
7 stars 10 forks source link

Filters can now be de-selected individually #649

Closed joshwingreene closed 2 years ago

joshwingreene commented 2 years ago

Changes

  1. Added a 'x' button to the left of the expand/collapse button that's a part of the FilterCategory component. It will only be shown when a filter is active. When clicked, the associated filter will be removed.
  2. Edited the styling of the FilterCategory styled component
  3. Corrected a bug in the DataTableSearchAndFilters component that was causing the following situation: if you had two filters that used the same operation and you removed one of them, it would remove both of them.

Purpose

Filters can now be de-selected individually

Testing Steps

  1. Pull in the changes to your local copy of this branch and run it alongside the dj_starter_demo repo.
  2. Add 2 filters and try to remove one of them.

Screenshots

https://user-images.githubusercontent.com/2876874/196542812-ea24cebd-7edb-43c6-8a63-bb0675e039b5.mov

Closes #619

joshwingreene commented 2 years ago

Data Table QA pass.