Closed joshwingreene closed 1 year ago
@joshwingreene Let's hold off on this one for now. I think we need a better solution here, this makes behavior too difficult to control between the various ways notifications are looked up, as notifications are also looked up when a new one comes in, and clicking on that notification should also mark it as read.
@joshwingreene Let's revisit this once I'm back after next week.
@joshwingreene I've reopened this and made a few changes, give it a look when you can :) Change summary is in the commit message.
@DropsOfSerenity Yeah. Your changes make sense to me. Nice work!
I did notice one issue. Marking a notification as read via the toast message doesn't cause the list of read notifications to automatically update. Was this intentional?
Marking a notification as read via the toast message doesn't cause the list of read notifications to automatically update. Was this intentional?
Nope, we definitely wanna get this fixed before it goes in too.
@DropsOfSerenity Understood. I'll go ahead and take care of this right now.
@DropsOfSerenity I wasn't able to fix the issue that I brought up here and in yesterday's standup. However, I did correct an issue that was causing the infinite loading logic to not function properly. Previously, the notification list would be reset when the "Load More" button was clicked.
Changes (Updated on Nov 30th)
BaseNotification
to standardize notification layout.useMarkRead
hook to handle the individual mark read functionalityremove
dispatch action touseLiveNotifications
to remove individual notifications.Purpose
Individual Notifications can now be marked as read
Approach
Testing Steps
Demo
https://user-images.githubusercontent.com/2876874/198729715-bd4f70ae-8978-4c6e-9c12-78c37747e1ce.mov