search

Shift3 / boilerplate-client-react

The Bitwise standard starting point for new React web projects.
7 stars 10 forks source link

Version AWS Provider #724

Closed michaelachrisco closed 1 year ago

michaelachrisco commented 1 year ago

Changes

  1. Hard set version of aws provider.

Purpose

To reduce potential future breakages within aws provider. Also maintains best practices around versioning/pulling outside resources.

Approach

Keep aws provider version attached to 4.0+

Learning

While this PR looks deceptively simple, we want to make sure nothing breaks because we are hard setting a version here. We will effectively be going from 5.8.0 -> 5.59.0. If Dashicorp is using semantic versioning then it shouldn't contain any breaking changes. However, in my experience, I have seen minor versions break within this provider...so its not a safe assumption here.

All our modules are using 5.8.0 to test with. Thats another conversion entirely.

Fortunately, the aws provider upgrades should no longer have breaking changes after 4.8.0. More info can be found here: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade

Pre-Testing TODOs

Run through terraform plan and make sure no breaking changes are introduced.

Testing

How should other contributors test this Pull Request?

  1. Pull in the changes to your local copy of this branch and restart Docker.
  2. run terraform plan
  3. see no hard changes within the infrastructure
  4. run terraform apply
  5. No errors should pop up

Closes #723

coreyshuman commented 1 year ago

@michaelachrisco is this still WIP as mentioned in the title?

coreyshuman commented 1 year ago

resolves https://github.com/Shift3/terraform-modules/pull/204

michaelachrisco commented 1 year ago

@michaelachrisco is this still WIP as mentioned in the title?

Thats on me, I removed off of one PR and not the other. Its been fixed.

Its ready to be reviewed, thanks!

coreyshuman commented 1 year ago

@michaelachrisco thank you for the learning section in your original post, that context is super helpful and going to be very useful when approaching terraform scripts moving forward.