search

Shift3 / boilerplate-client-react

The Bitwise standard starting point for new React web projects.
7 stars 10 forks source link

Accessibility improvements #764

Closed amerikan closed 1 year ago

amerikan commented 1 year ago

Changes

NOTE: this was individual volunteer work within my own personal capacity. I did it just for fun `¯_(ツ)/¯`_ Someone feel free to take over and make any code adjustments etc.

Purpose

For better accessibility.

Approach

How does this change address the problem?

Learning

Learned how to use i18next library :)

Pre-Testing TODOs

What needs to be done before testing

Testing

How should other contributors test this Pull Request?

  1. Pull in the changes to your local copy of this branch and restart Docker.

Screenshots

Closes #592, Closes #593, Closes #671

coreyshuman commented 1 year ago

Thanks for the PR Eric! We really want to build up community support for these internal tools so I appreciate you taking the initiative like this!

I actually just wrapped up a big i18n coverage PR which we merged into the develop branch. If you want to compare, check it out here: https://github.com/Shift3/boilerplate-client-react/pull/762

I missed some of the aria features so I'll definitely refer to this work to improve those things.

coreyshuman commented 1 year ago

I'm going to set this to a draft PR for now, since we want this type of feature work to go into the develop branch, and reserve main as a stable releases branch. That will let us reference this as we fix some of the a11y (which conveniently coincides with the QA pass we're doing right now!)

amerikan commented 1 year ago

@coreyshuman wow that's a large, but great change you've got there!

I'm not too familiar with this project, but wanted to check it out. It was a blunder on my part to use main thinking it was the development branch. I'm just so use to having the "development" branch as the default branch on github repos. It didn't even occur I was working off main (lol) and that there was an actual development branch called develop. As a suggestion, maybe change the default branch to be develop instead of main on this github repo?

If I have time, I can try to rebase some of the conflicts. I've used atomic commits, so in theory should be easy to resolve/revert individual changes. But makes sense to move it to draft. 👍🏼

coreyshuman commented 1 year ago

@amerikan if you can find the time, we'd love the support! If we get around to fixing this first, I'll make sure to close this PR and let you know.

amerikan commented 1 year ago

@coreyshuman should be good now. Basically removed all the translation stuff and kept the a11y changes. 👍🏼