Shift3 / boilerplate-client-react

The Bitwise standard starting point for new React web projects.
7 stars 10 forks source link

update codeowners using GitHub Team #768

Closed coreyshuman closed 1 year ago

coreyshuman commented 1 year ago

Changes

  1. Updated Codeowners file to reference a GitHub Team

Purpose

Codeowners referencing individuals requires extra maintenance a PR/review cycle to update, while a GitHub Team can be updated quickly by devops, ensuring more accurate permissions and security.

Approach

Update CODEOWNERS to reference a team instead of individuals. It is currently out of date, and referencing a team will make access management simpler by removing the need to make code changes as long as the team is maintained.

Learning

Devops is using this technique in their repos, example here: https://github.com/Shift3/terraform-modules/blob/develop/.github/CODEOWNERS

Closes #725