search

Shift3 / laptop

Setup any computer with sensible and extensible defaults for git, packages, editors and dotfiles.
MIT License
10 stars 9 forks source link

Bug: using diffopt+=vertical produces error when starting vim #24

Closed djagellon closed 3 years ago

djagellon commented 3 years ago

Not sure if this is considered a bug on our end since the error occurs with certain versions of macOS.

Starting with Catalina, the vertical value generates an error when starting vim:

E474: Invalid argument: diffopt+=vertical

See: https://github.com/thoughtbot/dotfiles/issues/655#issuecomment-605019271

Potential fix is to update the affected section in vimrc:

if &diff
    set diffopt+=vertical
endif
djagellon commented 3 years ago

@Endtry Trying to push a fix for this repo but I don't think I have write access.

DropsOfSerenity commented 3 years ago

@djagellon If you can make a pull request for this I can get it merged in.

djagellon commented 3 years ago

Thanks @DropsOfSerenity I tried to, but I don't seem to have write access to the repo.

DropsOfSerenity commented 3 years ago

@djagellon You'll want to fork the repository, then make a pull request from your fork :)

djagellon commented 3 years ago

ah. Thank you, I thought pulling and creating a new branch would be enough.