search

ShiftLeftSecurity / codepropertygraph

Code Property Graph: specification, query language, and utilities
Apache License 2.0
462 stars 73 forks source link

Will the `Hidden` defines in the schema be exported ? #1760

Open FFengIll opened 8 months ago

FFengIll commented 8 months ago

I see some nodes, edges, properties are defined in Hidden.scala, and they can not be used in protobuf and so on. Especially, the build logic filtered the Hidden.

May I kindly request an explanation for this behavior?

mpollmeier commented 8 months ago

Did you read the Hidden.description yet? That explains it

https://github.com/ShiftLeftSecurity/codepropertygraph/blob/d825dfdc2e50f9f664b857c84cce1447c720f983/schema/src/main/scala/io/shiftleft/codepropertygraph/schema/Hidden.scala#L9-L14

For reference, and a bit more context: https://github.com/ShiftLeftSecurity/codepropertygraph/pull/1340

FFengIll commented 8 months ago

Did you read the Hidden.description yet? That explains it

I am sorry I have not make a good issue, and I do review all content in the Hidden.

What I do really want to know is Can we update the schema? Or make the Hidden exported in protobuf?

Keep json schema is resonable, but why do not exported full protobuf define?

mpollmeier commented 8 months ago

I can see your point. @fabsx00 since you brought this in initially, do you have any thoughts on this?