search

ShiftLeftSecurity / codepropertygraph

Code Property Graph: specification, query language, and utilities
Apache License 2.0
462 stars 73 forks source link

Stats logger interceptor #1765

Closed pandurangpatil closed 1 month ago

pandurangpatil commented 7 months ago

Temporary mechanism to intercept the Passes and capture starting and ending events.

mpollmeier commented 6 months ago

Having the logger as a global object with mutable state seems like a bad idea, e.g. because we want to be able to run passes in parallel. Also, the initialise method isn't ever called, not sure how and if this even works...?

pandurangpatil commented 6 months ago

@mpollmeier @DavidBakerEffendi this is an temporary arrangement I am making to get some urgent troubleshooting done on customer on premise setup. As I don't have access to customer code, I need to get this one pushed for time being quickly. I will make sure in few days to update the original PR which will address the previous PR comments.

DavidBakerEffendi commented 6 months ago

@pandurangpatil Would it not make sense to then set up a local release on the customer's side? Or perhaps have a release for a Privado fork on this to benefit you guys in these situations long term?