search

ShifuML / shifu

An end-to-end machine learning and data mining framework on Hadoop
https://github.com/ShifuML/shifu/wiki
Apache License 2.0
251 stars 109 forks source link

Common Expression Validation Improvement #660

Open zhangpengshan opened 5 years ago

zhangpengshan commented 5 years ago

Some expression in filterExpression like ‘a > 0’ but data is 0.0 which is used to Long.parseLong("0.0") could be failed. But exception only in mapper logs, to improve it:

  1. Exception should be showed out to console
  2. How to build a UT or some tool or something to help user verify if the expression is correct or not
  3. Stats after filter expressions would be helped, like after filtering, 1000 records to 800 records