ShifuML / shifu

An end-to-end machine learning and data mining framework on Hadoop
https://github.com/ShifuML/shifu/wiki
Apache License 2.0
251 stars 109 forks source link

when binningMethod is EqualPositive, filter will not take effect in some columns #675

Open liweisnake opened 5 years ago

liweisnake commented 5 years ago

When column is numerical and is all negative, the filter will skip this column. Here if skip the column, it should be set to null, or the column stats data may be last stats value. https://github.com/ShifuML/shifu/blob/master/src/main/java/ml/shifu/shifu/udf/AddColumnNumAndFilterUDF.java#L171