Shigoto-dev19 ec-elgamal-circom issues - Githubissues

Shigoto-dev19 / ec-elgamal-circom

ElGamal encryption/decryption Circom2 circuits on the Baby Jubjub curve with TypeScript integration for input handling, testing, and benchmarking.

4 stars 1 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Comparison to your classic elgamal repository

#8 numtel opened 7 months ago
3
Why don't you call the variable encryptedMessage or encMsg directly?

#7 ananas-block closed 10 months ago
0
Use more descriptive naming and camelCase

#6 ananas-block closed 10 months ago
0
Use camel case for better readability isZ

#5 ananas-block closed 10 months ago
1
Interesting syntax, but is more difficult to understand than the gain here, I would put it into two lines.

#4 ananas-block closed 10 months ago
0
Why are you using <-- instead of <== ?

#3 ananas-block closed 10 months ago
0
Assert does not create a constraint if you want the check to hold against an attacker it needs to be a constraint

#2 ananas-block closed 10 months ago
0
Using an array component without a loop is a bit confusing, why not just use two?

#1 ananas-block closed 10 months ago
0