search

Shihira / gnome-extension-quicktoggler

DEPRECATED: Switched to KDE, so goodbye friends. Toggling services, launching apps in one click.
https://extensions.gnome.org/extension/1077/quick-toggler/
40 stars 9 forks source link

GNOME 3.36 compatibility #13

Open dolwup opened 4 years ago

dolwup commented 4 years ago

Quick Toggler does not work on GNOME 3.36. The icon appears in the top bar but nothing happens if you click on it.

Journalctl prints this error message for /usr/bin/gnome-shell:

Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'LOG_FILE' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'NOTIFICATION_COND' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'INDICATOR_ICON' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Usage of object.actor is deprecated for TogglerIndicator
                                                      get@resource:///org/gnome/shell/ui/environment.js:285:29
                                                      get_layout@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/extension.js:206:13
                                                      wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:82:27
                                                      _loadIcon@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/extension.js:251:18
                                                      wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:82:27
                                                      _loadSettings@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/extension.js:215:14
                                                      wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:82:27
                                                      _init@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/extension.js:198:14
                                                      wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:82:27
                                                      enable@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/extension.js:450:17
                                                      _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
                                                      _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:446:18
                                                      _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:445:11
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'INDICATOR_TEXT' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'ENTRIES_FILE' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'ConfigLoader' on the module 'core'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'SHOW_FILTER' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'DETECTION_INTERVAL' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code accessed the property 'MENU_SHORTCUT' on the module 'prefs'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: JS WARNING: [/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/extension.js 370]: reference to undefined property "MESSAGE_TRAY"
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array).
                                                      (Note that array.toString() may have been called implicitly.)
                                                      0 realPipeOpen/wait_cb/<() ["/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js":117:29]
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array).
                                                      (Note that array.toString() may have been called implicitly.)
                                                      0 realPipeOpen/wait_cb/</<() ["/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js":121:33]
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: JS WARNING: [/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js 254]: reference to undefined property "item"
Mar 12 15:35:36 dolwup-XPS-13-9370 gnome-shell[1400]: JS ERROR: TypeError: this.item is undefined
                                                      _loadState@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js:254:13
                                                      wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:82:27
                                                      pulse/<@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js:262:18
                                                      _detect/<@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js:226:13
                                                      realPipeOpen/wait_cb/</<@/home/dolwup/.local/share/gnome-shell/extensions/quicktoggler@shihira.github.com/core.js:124:17

Edit: I also found that this only happens if you have a toggler in your entries.json Edit: Updated the log I included to show more than just the repeating part

Shihira commented 4 years ago

Sad news here. I have switched to KDE for a few years because of some personal reasons, so the project may no longer be under maintance. My apology.

Meanwhile, PR is always welcome, or even ownership transfer is acceptable.