search

ShijieZhou-UCLA / feature-3dgs

[CVPR 2024 Highlight] Feature 3DGS: Supercharging 3D Gaussian Splatting to Enable Distilled Feature Fields
Other
317 stars 21 forks source link

A syntax mistake (perhaps) in CUDA submodule. #40

Closed ZhiyeTang closed 3 weeks ago

ZhiyeTang commented 3 weeks ago

I've checked your diff-gaussian-rasterization-feature CUDA module, and found that in cuda_rasterizer/backward.cu:line475-480, there is:

    if (inside)
        for (int i = 0; i < C; i++)
            dL_dpixel[i] = dL_dpixels[i * H * W + pix_id];
            dL_depth = dL_depths[pix_id];
        for (int i = 0; i < NUM_SEMANTIC_CHANNELS; i++) 
            dL_dfeaturepixel[i] = dL_dfeaturepixels[i * H * W + pix_id];

In CUDA syntax, because of missing curly braces, the scope of the if-condition is ambiguous.

ShijieZhou-UCLA commented 3 weeks ago

Thank you so much for your suggestions! I have just fixed it!