Shikhar15606 / react-native-accurate-step-counter

A react native library to accurately count the number of steps
https://www.npmjs.com/package/react-native-accurate-step-counter
MIT License
17 stars 13 forks source link

ios folder is redundant #2

Closed fobos531 closed 3 years ago

fobos531 commented 3 years ago

Hello,

First of all, I would like to give you my sincerest thanks for sharing this library, it has helped immensely in implementing a pedometer as part of on app I'm working on. Great work!

That said, I believe the ios folder is redundant in this project. If I attempt to install pods in my RN project, the command will fail due to an error in the podspec file. The homepage entry shouldn't be blank, but since the iOS part of the project is simply a placeholder, I figured it could be deleted altogether.

Let me know what you think regarding this :)

Abhishek357 commented 3 years ago

Glad to hear that it helped you. We haven't tested for the ios part. We will do it in the future and are also open to contribution :hugs:

cgruca commented 3 years ago

Hello, this package works great on android. Judging from the above, does this not work on IOS then?

Shikhar15606 commented 3 years ago

Yes, this package is only for android.

cgruca commented 3 years ago

Ah ok thanks for letting me know @Shikhar15606. Do you know if there's a good solution out there for ios? I know react-native-fitness is popular but that only updates steps every minute, while I need something like what you have here that updates constantly. Any help is appreciated, thanks!

Shikhar15606 commented 3 years ago

@cgruca , I am not aware of the solutions for ios. You can check this blog to create one, and I will be grateful if you will make a PR for the same. We are open to contribution 🤗

cgruca commented 3 years ago

Hello, I ended up going with a CMPedometer wrapper for ios - the one i used is react-native-pedometer-huangxt. Then i just check whether the platform is android or ios and use the corresponding package for it. Not the ideal solution but it's good enough.