ShikyoKira / Project-New-Reign---Nemesis-Main

Animation Behavior Patching Tool
GNU General Public License v3.0
461 stars 181 forks source link

The commit titled `Replaced codecvt with string reconstruction from character method` from April 14th of last year swapped completely correct code out for completely incorrect code, for seemingly no reason #673

Open Akira13641 opened 2 years ago

Akira13641 commented 2 years ago

This one, specifically.

transform_to will only work properly in contexts where the string being transformed (in either direction) does not actually contain bytes amounting to non-ASCII characters in the first place. Otherwise, it'll either throw something like std::range_error when called or simply produce output containing "garbage" characters.

This particular issue can be entirely resolved just by completely reverting the changes made by that commit.