search

Shimell / DiscordWhitelisterSpigot

Spigot plugin that allows whitelisting users through a discord text channel.
MIT License
41 stars 22 forks source link

New Feature Request 2.0 #2

Closed JamsRepos closed 5 years ago

JamsRepos commented 5 years ago

Cheers for that latest change, brilliant response time.

Possible to code in a limit system too as in able to specify a limit to how many whitelists you can have per user?

Would be brilliant to have for my SMP community where they can have say 3 whitelists of a friend.

If not, no problem!

Shimell commented 5 years ago

Should be possible but it would have to be in a separate discord role. I'll take a look into it.

JamsRepos commented 5 years ago

Should be possible but it would have to be in a separate discord role. I'll take a look into it.

No rush, could be done via specifying a limit per role?

Shimell commented 5 years ago

Yeah, I was thinking that the role of your choice (the whitelisted role for example) would store the persons discord id and how many times they have used the command. Just wondering if it would get fairly slow when it adds too many people, it should be completely fine though.

JamsRepos commented 5 years ago

How does the bot work in regards to people having _ in their name? For example, few of my players have underscores either side of their name and discord markdown converts that into italics. Does the bot pick up the username?

Shimell commented 5 years ago

If you're talking about their minecraft names the bot will pick it up just fine, it's just in discord that the name will appear altered. If you're on about their discord names you can just get their id which is stored as a number which also helps if they change their name later on. You can check the console when you whitelist someone and it will show you.

JamsRepos commented 5 years ago

Yeah I was talking about their minecraft name, that's fine though cheers.

Can't wait for the update if it comes, cheers for everything btw.

Shimell commented 5 years ago

@LubricantJam I added a limited whitelist role to the latest version (https://github.com/JoeShimo/DiscordWhitelisterBot-Spigot/releases/tag/1.0.5) if you wouldn't mind testing it for bugs, it seems to run fine but I may have missed something. You'll need to remove your old config and use the new one if you do, thanks.

JamsRepos commented 5 years ago

Seems to work fine :)