Shimmur / checker_cab

an extraction of assert_values_for
MIT License
23 stars 4 forks source link

Should work with a list of string field names #35

Closed idlehands closed 9 months ago

idlehands commented 9 months ago

Given that this tool originated to compare web inputs and the resulting database data, it would make sense if we could use parsed json as the source for the expected fields, which means string keys.

Looking at implementations, it felt like either ‘assert_values_for/1’ for ‘fields_for/1’ could be updated, but I think that ‘assert_values_for’ is the right solution, as using ‘fields_for’ isn’t required.

Under the hood, I think we just convert fields to atoms. just need to make sure we test edge cases around skip_fields as well.

idlehands commented 9 months ago

This is already built. Not sure why it appeared that it isn't.