search

Shimmur / checker_cab

an extraction of assert_values_for
MIT License
23 stars 4 forks source link

Chore/update elixir and otp and dependencies #38

Closed idlehands closed 8 months ago

idlehands commented 8 months ago

What does this do on a high level?

This updates the library to be compatible with the most current Elixir and OTP while maintaining backwards compatibility.

Bumps library version from 1.1 to 1.2.

This adds checks to this library's CI for the following versions:

Unfortunately, there conflicts with outdated dependencies. As a result, I updated all of the dependencies to they most current version.

The upgrade to Elixir 1.16 was causing some assertion areas where the test code was a little hand-wavy and so that had to be updated to a less flaky approach.

The PR was co-written with @GeoffreyPS, who added the version updates. The blame for the dependency updates and changes to testing approach lands on me.

How was this change made?

I added new entries to the matrix field in main.yml for the github configuration.

Dependencies in mix.exs were updated.

The approach to assert on the test message was updated.

Why is this change necessary?

This library should keep up with new versions of elixir so as to remain relevant.

How will this be verified?

Any additional information or special handling required on this PR?

motivational imagery a chimpanzee irons clothes

coveralls-official[bot] commented 8 months ago

Pull Request Test Coverage Report for Build 62c9b57bd2566a61011c8be6f8a257a55b3ce6fb-PR-38

Details

Totals Coverage Status
Change from base Build fe6675e07f11e1c42f144807ba446df69a6063da: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls
idlehands commented 8 months ago

@lmarlow Never got reports that it wasn't, BUT that's because it's very likely that anyone using it had newer versions of the dependencies as part of their application. So, practically, this was mostly impacting the ability to maintain the library.