search

Shimul-Baidya / MBDyn

GNU General Public License v2.0
1 stars 1 forks source link

Implementation Only Covers <one_body> Case in Body Class #13

Open Shimul-Baidya opened 2 weeks ago

Shimul-Baidya commented 2 weeks ago

Hey @zanoni-mbdyn,

I was reviewing the Body class implementation and noticed that it only covers the case. According to the MBDyn specification, the following cases should also be handled:

<one_pointmass>: This case is not currently covered, even though it represents a simpler definition with just mass.

<one_vm_body>: The implementation does not handle the variable mass body case, which requires additional elements like relative_center_of_mass, variable_mass_inertia_matrix, and variable_geometry_inertia_matrix.

condense with multiple masses: The implementation does not support the condense case, where multiple sub-masses are defined for a single body.

Body Element

Is there a specific reason why these cases were not included in the current implementation? Should we consider extending the class to handle these scenarios, or was there another approach in mind?

zanoni-mbdyn commented 1 week ago

Hi @Shimul-Baidya,

I don't know exacly why the implementation in the preprocessor is limited to the one body case, probably because no one ever needed to use the other cases with the PP, yet... ':)

I think that covering all the possible variants of Body is the correct way to go, even if it requires a bit more of effort.

Cheers, Andrea