Update for 3.3 Stable - Githubissues

SkanerSoft commented 3 years ago

Godot version: 3.3 stable

AdMob Plugin version: 4.1.1

Issue description: Crash on startup on my device. I cannot connect the phone to the computer for log with ADB

Lozamded commented 3 years ago

I have the same problem.

lettdev commented 3 years ago

Same problem confirmed.

Langrisser001 commented 3 years ago

Same problem, crash on startup.

I try running the demo, but the problem persist. I already follow the steps in Setup.

I don't know if this correlate with crash, but I found this in logcat

java.lang.RuntimeException: Unable to get provider com.google.android.gms.ads.MobileAdsInitProvider: java.lang.IllegalStateException:

******************************************************************************
* The Google Mobile Ads SDK was initialized incorrectly. AdMob publishers    *
* should follow the instructions here:                                       *
* https://googlemobileadssdk.page.link/admob-android-update-manifest         *
* to add a valid App ID inside the AndroidManifest.                          *
* Google Ad Manager publishers should follow instructions here:              *
* https://googlemobileadssdk.page.link/ad-manager-android-update-manifest.   *
******************************************************************************

choyg commented 3 years ago

It's a simple fix. Check my fork's diff. I also published a release for your convenience. You can grab the other admob-lib files from this repo.

choyg commented 3 years ago

Fwiw the underlying admob library is evolving as well so there's likely going to be additional breaking changes needed if people want to use the latest and greatest on both Godot and Admob.

raeddarweesh commented 3 years ago

Thank you @choyg. Your fork is working perfect.

Shin-NiL commented 3 years ago

New version released.

Shin-NiL / Godot-Android-Admob-Plugin

Update for 3.3 Stable #146