search

Shin-NiL / Godot-Android-Admob-Plugin

Android AdMob plugin for Godot Game Engine 3.2 or higher
MIT License
543 stars 66 forks source link

Loading a banner displays it automatically. #185

Closed Torguen closed 2 years ago

Torguen commented 2 years ago

Godot version: 3.4.1 rc1 mono AdMob Plugin version: 5.1.0 Issue description: Loading a banner displays it automatically. Even if the user never did "show_banner".

To fix this call "hide_banner" immediately after "load_banner".

The expected is to use "load_banner" and not show the ad until the user calls "show_banner".

vetu11 commented 2 years ago

I think this is the intended behavior.

Shin-NiL commented 2 years ago

I can confirm this is the expected behavior.

Torguen commented 2 years ago

Ah well I would expect what I mentioned in the report. I didn't do show_banner so why does the banner show automatically?

It would make sense to put "show_banner" in the broadcast of the "banner_loaded" signal, that makes sense to me.

Shin-NiL commented 2 years ago

This is a "legacy" behavior from an old lib. I agree it could be changed in the future.