search

Shin-NiL / Godot-Android-Admob-Plugin

Android AdMob plugin for Godot Game Engine 3.2 or higher
MIT License
543 stars 66 forks source link

WIP: Godot 3.4.5 and SDK 31 #200

Closed Funmungus closed 2 years ago

Funmungus commented 2 years ago

build.gradle: Temporarily set compileSdk and build tools to 31 explicitly. Godot now targets 31, but the config.gradle still sets compileSdk 30. export_presets: target SDK 30. Request permission AD_ID, required by Google services and Play store. README: Add a note for a temporary workaround to compile with SDK 31.

Funmungus commented 2 years ago

@Shin-NiL I have confirmed this works with compile SDK 31, but it includes manual steps. There is a temporary addition to the README that clarifies this, but in short, the Godot application has to modify config.gradle in addition to AndroidManifest. Due to these manual steps being temporary, and only a workaround until Godot 3.5, I am not sure you actually want to merge this code. I have done the work for my own app, so now I make it available to you.

Shin-NiL commented 2 years ago

@Funmungus Nice, I think it's fine to use the workaround. I'll merge it and publish it asap, thanks again.

Funmungus commented 2 years ago

@Shin-NiL I was wrong about the com.google.android.gms.permission.AD_ID permission. This is only for personalized ads, and is not required for all projects.