Shin-NiL / Godot-Android-Admob-Plugin

Android AdMob plugin for Godot Game Engine 3.2 or higher
MIT License
543 stars 66 forks source link

Let the dev rename the AdMob Singleton #215

Open LazyDridri opened 1 year ago

LazyDridri commented 1 year ago

Godot version: 4.0.2

AdMob Plugin version: 6.1.1

Issue description:

I renamed my singleton Admon_Android (since it is not working on iOS for now and wanted to ifnd an other solution for this) and I found out that I should not have done that.

It could be nice to rework just a little bit the admob.gd by checking if there is only 1 class_name AdMob in the scene OR by improving the debug message with: "AdMob Java Singleton not found. This plugin will only work on Android. NOTE : Make sure you have not renamed the Admod Node (should be GodotAdmob) "