Shinkai125 / Band

Keras For NLP
Apache License 2.0
1 stars 0 forks source link

Refactor transformer.py:Transformer(vocab_size,maxlen,embed_dim,num_heads,feed_forward_dim) #5

Open Shinkai125 opened 4 years ago

Shinkai125 commented 4 years ago

I've selected transformer.py:Transformer(vocab_size,maxlen,embed_dim,num_heads,feed_forward_dim) for refactoring, which is a unit of 7 lines of code and 5 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! πŸ‘

Here's the gist of this guideline:

You can find more info about this guideline in Building Maintainable Software. πŸ“–


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the πŸ”² next to them. The risk profile below the candidates signals (βœ…) when it's enough! 🏁


Good luck and happy coding! :shipit: :sparkles: :100:

github-actions[bot] commented 3 years ago

Stale issue message