Shinkai125 / Band

Keras For NLP
Apache License 2.0
1 stars 0 forks source link

Refactor Distiller.compile(optimizer,metrics,student_loss_fn,distillation_loss_fn,alpha,temperature) #6

Open Shinkai125 opened 4 years ago

Shinkai125 commented 4 years ago

I've selected Distiller.compile(optimizer,metrics,student_loss_fn,distillation_loss_fn,alpha,temperature) for refactoring, which is a unit of 6 lines of code and 6 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

Here's the gist of this guideline:

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: :sparkles: :100:

github-actions[bot] commented 3 years ago

Stale issue message