search

Shinmera / cl-spidev

A library for the Linux SPIDEV kernel module as used on hobby kits such as the Raspberry Pi
https://shinmera.github.io/cl-spidev/
zlib License
5 stars 4 forks source link

TRANSMIT possibly broken? #4

Open 3b opened 6 years ago

3b commented 6 years ago

Not completely sure what is happening, but I think TRANSMIT (or (setf IOCTL)) is broken. I get "message too long" errors from it, which I think are caused by it passing an address to (setf ioctl), which then passes a pointer to that address to the actual ioctl. If I use sb-posix:ioctl instead with otherwise same code, I get valid looking data back with no errors.

Sod-Almighty commented 3 years ago

PSA to anyone who finds this repo in the future:

THIS LIBRARY IS COMPLETELY BROKEN (And always has been.)

It has taken me three solid days of coding just to get it to do something useful. It's garbage. Don't try to use it.

Shinmera commented 3 years ago

Wow cool, thanks dude.

Sod-Almighty commented 3 years ago

What do you expect when you ignore open issues for three years, and when you clearly didn't even run your own code?

As "3b" says above - and as I struggled for a whole day yesterday to fix - you're sending a pointer-to-pointer-to-struct to ioctl().

Shinmera commented 3 years ago

How about asking for help instead? Something like "Hi, I was trying to use your library, but ran into this issue as well. Is there any chance of it getting fixed soon? Thanks!"

We're all busy people and have other things to do. Prodding someone for response is however much more likely to succeed than insulting them and venting your anger at hem. As it stands I don't particularly feel like helping you. Sorry.

Sod-Almighty commented 3 years ago

I did. I opened an issue the other day. And "3b" opened one three years ago. Didn't seem to help him much.

Shinmera commented 3 years ago

That's still no reason to scream at other people. The library was tested and worked when it was initially released. It has since fallen to the wayside as I hadn't made use of it in a while and nobody else stood up to maintain it.

Sod-Almighty commented 3 years ago

Didn't scream. Put up a PSA to keep any other poor buggers from wasting a week trying to get it working.

It clearly did NOT work when it was initially released, because AT NO POINT did ioctl() expect a pointer-to-pointer-to-struct. Linux hasn't changed that much in four years, else thousands of other programs would have stopped working.

Stop trying to paint me as unreasonable. It's not like I insulted you. I merely pointed out facts.

If you'd bothered to reply to the issues, the situation would not have arisen.

Shinmera commented 3 years ago

I'm not sure what part of bold and caps lock isn't screaming, or what part of labelling things as "completely broken" and "garbage" isn't insulting, but I hope you feel better soon.

Sod-Almighty commented 3 years ago

Again, you're ignoring the fact that YOU are in the wrong here. You, personally, have wasted three days of my life.

This is what is wrong with open source.

  1. Put broken code up on github
  2. Wait for people to open issues
  3. Ignore issues
  4. Wait for people to complain
  5. Attack them

Or, alternatively:

  1. Put broken code up
  2. Wait for people to open issues
  3. Tell them it's "open source" and therefore THEY have to fix the issues themselves.
Shinmera commented 3 years ago

I sincerely hope you feel better soon.