search

Shinmera / parachute

An extensible and cross-compatible testing framework.
https://shinmera.github.io/parachute
zlib License
94 stars 9 forks source link

Unicode characters in plain report are not monospace #4

Closed phoe closed 5 years ago

phoe commented 5 years ago

This is purely a client-side issue, but nonetheless: The unicode question marks used in Parachute are not monospace and are therefore triggering my OCD making the report hard to read for me.

Lines 44 and 45 should be indented the same way, but line 45 is off due to the Unicode question mark: zrzut ekranu z 2018-09-24 19-22-28

Example test report: https://plaster.tymoon.eu/view/931#931

Could you replace the unicode question mark with a standard ASCII one? (The tick and the cross display as monospace enough.) If not, could you make the set of characters/strings used in there configurable? I see you are setting a compile-time property for Unicode dependencies, but I'd prefer something that I can switch at runtime.

Shinmera commented 5 years ago

Use fonts that don't suck include them in the monospace variants, like the Noto family.

The unicode-ness is already controlled by the presence of the asdf-unicode feature, so do with that as you like.

phoe commented 5 years ago

I don't even know which font is being used in my web browser. I'm using Iosevka inside my Emacs and it doesn't seem to include it, either.

zrzut ekranu z 2018-09-24 19-29-26

I'll likely submit a PR that controls this.

Shinmera commented 5 years ago

Also, ascii does not include a tick, so idk what you're on about.

phoe commented 5 years ago

Honestly, I just wish I could replace the question mark with the ASCII one, because the tick works well enough.

Shinmera commented 5 years ago

I could remove the skip and unknown full-width characters, I suppose.

Shinmera commented 5 years ago

In any case, I heavily recommend either using Noto primarily, or at least setting it up as a high fallback font.

phoe commented 5 years ago

This is becoming off-topic, but - how can I set it as a fallback font in my system and in my emacs?

Shinmera commented 5 years ago

Actually, nvm, using the plain versions causes alignment problems on my setup thunk

phoe commented 5 years ago

Wait a second, plain versions are off on your machine?

thonk

Shinmera commented 5 years ago

Googling for that helps. http://eosrei.net/articles/2016/02/changing-default-fallback-subsitution-fonts-linux

Shinmera commented 5 years ago

2018-09-24-194137_521x242_scrot

phoe commented 5 years ago

oh right, it seems that on your machine, for some reason, the ticks are as wide as the question marks, so it all evens out.

welp²

Shinmera commented 5 years ago

if only there was an alignment character.

phoe commented 5 years ago

ooh, alignment, like this? shitpost

Shinmera commented 5 years ago

No, like what the Tab character was initially meant to do.