search

Shinmera / parachute

An extensible and cross-compatible testing framework.
https://shinmera.github.io/parachute
zlib License
97 stars 9 forks source link

Add *status-indicators* plist #52

Closed yitzchak closed 1 year ago

yitzchak commented 1 year ago

Adds *status-characters* plist so that the various status indicators can be customized. This is useful when the terminal (or browser for CI) font doesn't support the default indicators.

Shinmera commented 1 year ago

I'd name the variable *status-indicators*. characters is a misnomer, since they're not actual characters.

yitzchak commented 1 year ago

Should the function status-character be renamed as well?

Shinmera commented 1 year ago

Hrmmm. Looks like it's exported, so changing it would unfortunately break compatibility.

yitzchak commented 1 year ago

Another alternative would be to leave the function status-character as is and add a generic status-indicator that defaults to calling status character. Just a thought.

Shinmera commented 1 year ago

I don't think it's worth over-engineering this problem to such an extent. I believe the original intention of exporting status-character was even to allow people to customise it by just redefining it.

yitzchak commented 1 year ago

Ok. Renamed the variable. I can squash if you want.

Shinmera commented 1 year ago

Thanks, sorry for the back and forth.

yitzchak commented 1 year ago

No worries. Doesn't bother me at all.

Thanks!